search

easifem / base

Expandable And Scalable Infrastructure for Finite Element Methods, EASIFEM, is [Modern Fortran](https://fortran-lang.org) framework for solving partial differential equations (PDEs) using finite element methods. EASIFEM "eases" the efforts to develop scientific programs in Fortran.
https://www.easifem.com
Other
8 stars 2 forks source link

Fixing bug in ReferenceQuadrangle_Method #280

Closed vickysharma0812 closed 9 months ago

vickysharma0812 commented 9 months ago
Generated summary (powered by Graphite) > ## TL;DR > This pull request modifies the `ReferenceQuadrangle_Method@Methods.F90` file to fix an issue with the `InterpolationPoint_Quadrangle` function call. The `xij` parameter now correctly uses the entire `refelem%xij` array instead of a subset. > > ## What changed > In the `ReferenceQuadrangle_Method@Methods.F90` file, the `InterpolationPoint_Quadrangle` function call was modified. Previously, it was using a subset of the `refelem%xij` array (`refelem%xij(1:3, 1:4)`). Now, it uses the entire array (`refelem%xij`). > > ```diff > - & xij=refelem%xij(1:3, 1:4), & > + & xij=refelem%xij, & > ``` > > ## How to test > To test this change, you can run the existing unit tests for the `ReferenceQuadrangle_Method@Methods.F90` file. If the tests pass, it indicates that the change is working as expected. If there are no existing tests, consider adding some to verify the correct behavior of the `InterpolationPoint_Quadrangle` function call. > > ## Why make this change > This change is necessary because the previous code was not using the entire `refelem%xij` array, which could lead to incorrect results. By using the entire array, we ensure that the `InterpolationPoint_Quadrangle` function has all the necessary data to perform its calculations correctly.
vickysharma0812 commented 9 months ago

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.