easingthemes / ssh-deploy

GitHub Action for deploying code via rsync over ssh. (with NodeJS)
MIT License
1.19k stars 146 forks source link

Error on deployment... worked well up until now #118

Closed karfu-git closed 1 year ago

karfu-git commented 1 year ago

Hi! I've been using this package as part of my deployment process for some time now, today I got the following error when my pipeline ran...

/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2

TypeError: Cannot read properties of undefined (reading 'split')
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:4450
    at Array.forEach (<anonymous>)
    at Object.229 (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:43[19](https://github.com/karfu-git/Laravel-Ingester/actions/runs/4233945900/jobs/7355630423#step:12:20))
    at __nccwpck_require__ (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:8812)
    at Object.976 (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:4805)
    at __nccwpck_require__ (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:8812)
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:9078
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:9799
    at Object.<anonymous> (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:98[20](https://github.com/karfu-git/Laravel-Ingester/actions/runs/4233945900/jobs/7355630423#step:12:21))
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
williamspencer commented 1 year ago

Hi! I've been using this package as part of my deployment process for some time now, today I got the following error when my pipeline ran...

/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2

TypeError: Cannot read properties of undefined (reading 'split')
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:4450
    at Array.forEach (<anonymous>)
    at Object.229 (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:43[19](https://github.com/karfu-git/Laravel-Ingester/actions/runs/4233945900/jobs/7355630423#step:12:20))
    at __nccwpck_require__ (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:8812)
    at Object.976 (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:4805)
    at __nccwpck_require__ (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:8812)
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:9078
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:9799
    at Object.<anonymous> (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:98[20](https://github.com/karfu-git/Laravel-Ingester/actions/runs/4233945900/jobs/7355630423#step:12:21))
    at Module._compile (node:internal/modules/cjs/loader:1105:14)

can confirm I'm experiencing same issue as well.

A0dh commented 1 year ago

Same issue on my end

A0dh commented 1 year ago

Using the version easingthemes/ssh-deploy@v4.1.0 for now. Seems to be working fine.

karfu-git commented 1 year ago

Using the version easingthemes/ssh-deploy@v4.1.0 for now. Seems to be working fine.

Well caught @A0dh ..Up and running again

ivansivaklepsi commented 1 year ago

Same is happening for me, suddenly the deploy stopped working

easingthemes commented 1 year ago

I'll check now

easingthemes commented 1 year ago

Update merged, check with @ main or v4.1.5

easingthemes commented 1 year ago

Issue is auto closed with a merge, reopen if it still happens.

easingthemes commented 1 year ago

Can you please also add your setup / list of envs, so I can add this case in e2e tests

karfu-git commented 1 year ago

Can you please also add your setup / list of envs, so I can add this case in e2e tests

Sure, my set up is as follows...

SSH_PRIVATE_KEY: ${{ secrets.KEY }}
REMOTE_HOST: ${{ env.HOST }}
REMOTE_USER: ${{ secrets.USER }}
TARGET: ${{ env.TARGET }}

My remote host is an AWS EC2, if that helps at all, so just using the hostname for that particular parameter.

Thanks for looking at this so quickly!