easingthemes / ssh-deploy

GitHub Action for deploying code via rsync over ssh. (with NodeJS)
MIT License
1.17k stars 144 forks source link

Support GH Action Highlight #149

Closed Triloworld closed 1 year ago

Triloworld commented 1 year ago

Plugin take overhead from this repo when comes to writing Github Action Issue is when we try go along with readme

Plugin in VS Code: https://github.com/github/vscode-github-actions

This give error:

Zrzut ekranu 2023-05-16 o 13 01 01

This will be ok:

Zrzut ekranu 2023-05-16 o 13 04 22

Maybe fix readme? What is proper approach?

AlexDroomer commented 1 year ago

Hi, @Triloworld , you can leave the options only in the with block and remove the env block, everything will work as it should, the README does not really specify this, but in the file action.yml is written not required/required variables

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Triloworld commented 1 year ago

GitHub Action documentation: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepswith You are right. This file describe it as INPUT: https://github.com/easingthemes/ssh-deploy/blob/main/action.yml You can merge change into readme if that's ok for you and close issue. For me it will align with other tools that are strict regarding checking syntax. Thank you for this action :) Work great overall.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Triloworld commented 1 year ago

@AlexDroomer is there issue to merge pull request?

AlexDroomer commented 1 year ago

@Triloworld I don't know, I don't have permission to mergešŸ¤–

Triloworld commented 1 year ago

@sdelfi @easingthemes ? Can be check and merged?

easingthemes commented 1 year ago

Merged, thanks.