easlice / bandcamp-downloader

Download your bandcamp collection using this python script.
MIT License
281 stars 34 forks source link

Dean/package manage with poetry #1

Closed deanputney closed 2 years ago

deanputney commented 2 years ago

This change manages required packages and Python version using Poetry. The reasons I'm suggesting this change are:

This doesn't prevent a user from running the script on their local installation, if they desire.

Give it a try, let me know what you think!

easlice commented 2 years ago

Hey, thanks for the PR!

This looks pretty good. Following the instructions on my local system work, so that seems good.

How about leaving both sets of instructions in the README, one for non-poetry installs and one for using poetry? I know if I had come across this before, not knowing what poetry was, I would have seen this and assumed it was necessary, which would make me skip by using it, since I don't normally use poetry and wouldn't install it for a one off script like this.

You can decide the verbiage, or I can do it after merging the PR, doesn't matter to me, I just want it clear that poetry isn't necessary to run it.

deanputney commented 2 years ago

In the case that you want to support running this directly as well, I would recommend that we add a requirements.txt so that the packages can be installed automatically with pip install -r requirements.txt. I've added that as well as a description to the README.

easlice commented 2 years ago

Agreed about the requirements.txt. And the contributing section is a nice touch.

And I appreciate the help from someone who seems to work more professionally in python than I do.

I'm going to resolve the conflict from my known issues section, merge this in, then tweak it a bit.

deanputney commented 2 years ago

Happy to help! Nice to get a clean PR in every once in a while 🧼