easly1989 / ffxiv_act_dfassist

Duty Finder Assist Plugin for ACT, Based on https://github.com/devunt/DFAssist
GNU General Public License v3.0
83 stars 37 forks source link

Version 1.5.0 prevent Triggernometry from loading #9

Closed ghost closed 5 years ago

ghost commented 5 years ago

ACT 3.4.0 Release 260 DFAssist 1.5.0 FFXIV_ACT_Plugin 2.0.2.7 Triggernometry 1.0.9.1 OverlayPlugin 0.3.7.0

image

When I disable DFAssist Triggernometry will load successfully

image

easly1989 commented 5 years ago

Noticed. The strange thing is that the error gets triggered by Triggernometry (so I can't actually debug it)

I suppose it is connected to some event handing i do that triggers thing in that plugin too for some reason.

As soon as I get home I'll investigate and report back!

Sorry for the inconvenience 😣

easly1989 commented 5 years ago

I have tested multiple time, with the same exact version you have of Triggernometry and I'm unable to reproduce the problem.

I'm unable to debug having triggernometry as a plugin (but that happens even if I don't have DFAssist on..)

immagine

I'll leave this open; But it may be something to debug/understand with the help of @paissaheavyindustries

ghost commented 5 years ago

Currently using updated DFAssist version 1.5.1

After i saw your plugin load order, i tried that order. it works. i load DFAssist after FFXIV_ACT_Plugin.

image

when i put DFAssist before FFXIV_ACT_Plugin the error comes back.

easly1989 commented 5 years ago

How did i not noticed that!? 😵 Anyway, I dunno if it is a common thing for all the plugins.. But DFAssist needs the FFXIV plugin to be installed first.

For this reason I'll add a check, and prevent the plugin from loading if it doesn't find the parsing plugin first!

ghost commented 5 years ago

Usually I load everything after FFXIV_ACT_Plugin. I loaded DFAssist first because I was following frontpage guide.

image

I'm glad it works now. Thank you for your help

easly1989 commented 5 years ago

Usually I load everything after FFXIV_ACT_Plugin. I loaded DFAssist first because I was following frontpage guide.

image

I'm glad it works now. Thank you for your help

Yeah, I have to update the front page, as the ACT is now updated In the older version of it, the plugin were loaded from bottom to top. Now it seems that they are loaded from to bottom ^^'...

Anyway, glad that the issue was addressed, Have fun :)