search

eastee / rebreakcaptcha

MIT License
750 stars 138 forks source link

Add dependancies as requirements.txt #2

Closed amitness closed 7 years ago

amitness commented 7 years ago

A requirements.txt file allows easy installation of all 3rd party libraries that the project depends on. I've generated that file for this script and also included instruction on how to use it in README.

eastee commented 7 years ago

The following packages are not necessary: appdirs, packaging and pyparsing. Mind to shed some light as to why do you see them as required?

amitness commented 7 years ago

The libraries that the project depends on are themselves built on top of some other 3rd party libraries.

For example, Flask is a popular web development framework which itself is built upon Jinja2 library. So when you install Flask, Jinja2 is autoinstalled.

In your case, the libraries such as pydub and SpeechSynthesis might be dependant on these, so they're auto included in requirements.txt.

eastee commented 7 years ago

I reviewed this requirements file again. I do not think 'six' has a room here because it is not being used (I'm aware of its functionality). Also, when installing dependencies using 'requirements.txt' file- any sub-dependencies (appdirs, packaging and pyparsing) are automatically installed. I do not think they should be included.

amitness commented 7 years ago

@eastee I made the changes. I guess, it's good to merge now.

eastee commented 7 years ago

Thank you for your contribution 👍