search

easternbloc / node-stomp-client

A STOMP client for Node.js
Other
93 stars 47 forks source link

TLS support #26

Closed the-nicolas closed 9 years ago

the-nicolas commented 10 years ago

The STOMP server we are connecting just supports TLS/SSL connections. ...but the client seems not to support that.

Is that feature planed or is there a fork that already supports encrypted connections?

sam-github commented 10 years ago

I haven't used it, but TLS support appears to exist, does it not work?

https://github.com/easternbloc/node-stomp-client/blob/master/lib/client.js#L257

dvtylr commented 9 years ago

The SecureStompClient code no longer worked as it relied on an API that is no longer available in node. I have created a PR for TLS support. Necessary changes were minor but I also allowed for the constructor to accept options as an object so I did not need to pass in so many nulls.

mantoni commented 9 years ago

I'm connection with SSL on node 0.10.38. Works fine for me:

// removed missleading example code snippet
dvtylr commented 9 years ago

Are you sure you are using this module? The syntax you are using looks like it is for stomp-js and not stomp-client.

mantoni commented 9 years ago

Oh, I'm very sorry. You're right @dvtylr.

easternbloc commented 9 years ago

Feature available in 0.7.0 added by @dvtylr in PR #46 closing this ticket now.