search

easternbloc / node-stomp-client

A STOMP client for Node.js
Other
93 stars 47 forks source link

Fix issue #29: Parsing of header values that include embedded colons (':'). #30

Closed kgoerlitz closed 9 years ago

kgoerlitz commented 9 years ago

When using ActiveMQ with temporary queue in reply-to header, the resulting value includes ':' characters, which was causing the parser to only use the first part of value up to the first ':' as the header value.

easternbloc commented 9 years ago

The tests fail for this?

kgoerlitz commented 9 years ago

There previously was not a test for this case. I modified on of the tests to set and test the message-id with a value that includes embedded colons.

My change fixes the problem and lets the full ActiveMQ temporary queue name to come through on the reply-to header.

    Thanks - Kevin G.

-----Original Message-----From: Ben Marvell notifications@github.com Reply-to: easternbloc/node-stomp-client <reply +008ec191dc68d1f01f3f02aedb4b5d9447ac276988717e5f92cf0000000110cf543392a169ce033bd2bb@reply.github.com> To: easternbloc/node-stomp-client node-stomp-client@noreply.github.com Cc: kgoerlitz kevin.goerlitz.01@gmail.com Subject: Re: [node-stomp-client] Fix issue #29: Parsing of header values that include embedded colons (':'). (#30) Date: Thu, 15 Jan 2015 02:10:59 -0800

The tests fail for this?

— Reply to this email directly or view it on GitHub.