search

easternbloc / node-stomp-client

A STOMP client for Node.js
Other
93 stars 47 forks source link

This is the fix for utf8 support #4

Closed datafatmunger closed 10 years ago

datafatmunger commented 12 years ago

Here is the fix for the utf8 support I created an issue about. Thanks for your work on the module!

travisbot commented 12 years ago

This pull request passes (merged 8d53460c into 0df601b6).

easternbloc commented 12 years ago

I'd be happy to look at adding this if you can write me some unit tests to show the issue.

Cheers.

datafatmunger commented 12 years ago

I plan on it. Just need to make some time. Perhaps this weekend. The test is simple you can't assume the content length is equal to the string length when dealing with UTF8.

easternbloc commented 12 years ago

Cheers, if you don't get time please let me know and I'll try and knock something up.

travisbot commented 12 years ago

This pull request passes (merged 91ed0c81 into 0df601b6).

jangie commented 10 years ago

Is there going to be any movement on this pull request? Just ran into this issue and would like to know.

easternbloc commented 10 years ago

I can merge it in I'd just rather have a failing test to show the use case first. Any chance you could PR one @jangie?

jangie commented 10 years ago

Just as a note, the first test is passing [expected, it's all single-byte UTF-8 characters], whereas the second one is failing, as each of the characters in the body of the message in that test is actually three bytes of data.

While the characters I have chosen may not commonly come up (especially the snowman), this would be a problem for many more non-fun use cases (see, for example, Korean/Chinese/Japanese characters)