eastgenomics / eggd_artemis

Creates download urls for files required and outpus in a text file to be shared with the scientists
0 stars 0 forks source link

DI-601 v1.4.0 Variant counts and multiple reports per sample #19

Closed rklocke closed 8 months ago

rklocke commented 8 months ago

Changes

Example test jobs New format Excel report metadata (clinical indications and variant counts) present, reports split per sample by panel, cells locked, MultiQC report given as input. One sample (line 586) is split into multiple reports. Job: https://platform.dnanexus.com/panx/projects/Gf1JZfQ4FBj30ZjFQjKp3FQ3/data/?scope=project&id.values=file-GfPGxJ84FBjFB9P06Qf0q1F9

As current set up No Excel report metadata (counts or clinical indications) present for these reports so no clinical indications or counts present or links removed in final Excel. Reports aren't split by clinical indication so only a single report given back per sample. Excel cells not locked for editing Job: https://platform.dnanexus.com/panx/projects/Gf1JZfQ4FBj30ZjFQjKp3FQ3/monitor/job/GfPv29Q4FBjFb5y3ykXk7P08


This change is Reviewable

pep8speaks commented 8 months ago

Hello @rklocke! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 20:1: E402 module level import not at top of file Line 343:5: E303 too many blank lines (2) Line 892:80: E501 line too long (116 > 79 characters)

Comment last updated at 2024-01-11 15:15:26 UTC