search

eastgenomics / eggd_artemis

Creates download urls for files required and outpus in a text file to be shared with the scientists
0 stars 0 forks source link

minor refactor for sanity and readability #23

Open jethror1 opened 1 month ago

jethror1 commented 1 month ago

this mess of appends could / should be refactored into the initial df creation: https://github.com/eastgenomics/eggd_artemis/blob/d31e869494fa3f441ba17657f34c23cb5b40974d/src/eggd_artemis.py#L785-L801

pd.DataFrame([
    {'a': 'Run', 'b' project_name},
    {'a': 'Number of samples in this file:', 'b': sample_count}
    ...
])

no idea what I was thinking when I wrote it initially but it ain't great