eastgenomics / eggd_artemis

Creates download urls for files required and outpus in a text file to be shared with the scientists
0 stars 0 forks source link

v1.5.0 - Get excluded regions file-id #25

Closed growland2 closed 3 months ago

growland2 commented 3 months ago

Add feature to retrieve excluded regions file-id


This change is Reviewable

pep8speaks commented 3 months ago

Hello @growland2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 295:80: E501 line too long (91 > 79 characters)

Comment last updated at 2024-06-13 11:09:14 UTC
growland2 commented 3 months ago

Built app with a temporary print statement to print out the cnv files dictionary, inspection of the job logs shows that the excluded region files is correctly included in the printed cnv files dictionary https://platform.dnanexus.com/panx/projects/GkbBjJ04Pqj2Q3J597Q3gKJx/monitor/job/GkbFZy84Pqj45x72X698Xxv9

rklocke commented 3 months ago

Checked that it's the correct excluded regions file ID for the sample :)