Improve value type checking for hyperlink values - Githubissues

eastgenomics / eggd_generate_variant_workbook

DNAnexus app for generating xlsx variant workbooks

3 stars 0 forks source link

Improve value type checking for hyperlink values #111

Closed jethror1 closed 2 years ago

jethror1 commented 2 years ago

Instead of checking column type, can use the excel.is_numeric() method to better check the type of every value before returning the URL here

https://github.com/eastgenomics/eggd_generate_variant_workbook/blob/f35a4633abcb8a976bb7c676e51d067aff7940d9/resources/home/dnanexus/generate_workbook/utils/excel.py#L538-L554