Closed jethror1 closed 2 years ago
Hello @jethror1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Line 382:28: W605 invalid escape sequence '\d' Line 382:32: W605 invalid escape sequence '\d'
Line 33:5: E303 too many blank lines (2) Line 48:5: E303 too many blank lines (2) Line 63:5: E303 too many blank lines (2)
Line 509:5: E303 too many blank lines (2)
Summary
Adds ability to pass in images to write to extra sheets in the workbook (i.e. graphs), can control sheet naming and image sizes with additional arguments
-iimage_sheet_names
and-iimage_sizes
respectively.If size not specified, will default to maximum of 90% of 1920*1080, retaining original image aspect ratio to fit nicely on standard 1080p monitors.
Python packages added:
Pillow
- used by openpyxl for handling image writingfilteype
- used ingenerate_workbook.verify_images
to check if image files have been passedNew functions
generate_workbook.verify_images
: assertions to check validity of given image related argumentsexcel.write_images
: controls writing of images to new sheetsExample jobs and outputs
-iimage_sheet_names="thisIsFine" -iimage_sizes="960:540"
): https://platform.dnanexus.com/projects/GFFvFG042Zj7FxK74bpKVbjV/monitor/job/GFjP8B042Zj78bZBGgJJ8XFp-iimage_sheet_names="thisIsFine aNiceGraph" -iimage_sizes="960:540 1440:810"
): https://platform.dnanexus.com/projects/GFFvFG042Zj7FxK74bpKVbjV/monitor/job/GFjPK3Q42Zj711yx90y9Zx8BUnit tests
This change is