eastgenomics / eggd_generate_variant_workbook

DNAnexus app for generating xlsx variant workbooks
3 stars 0 forks source link

Optional image writing to additional sheets #116

Closed jethror1 closed 2 years ago

jethror1 commented 2 years ago

Summary

Adds ability to pass in images to write to extra sheets in the workbook (i.e. graphs), can control sheet naming and image sizes with additional arguments -iimage_sheet_names and -iimage_sizes respectively.

If size not specified, will default to maximum of 90% of 1920*1080, retaining original image aspect ratio to fit nicely on standard 1080p monitors.

Python packages added:

New functions

Example jobs and outputs

image

image

image

image

image

Unit tests

$ python3 -m pytest resources/home/dnanexus/generate_workbook/tests/
==================================== test session starts =====================================
platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.0.0
rootdir: /home/jethro/Projects/eggd_vcf2xls_nirvana/resources/home/dnanexus/generate_workbook/tests, configfile: pytest.ini
collected 35 items                                                                                                                               

resources/home/dnanexus/generate_workbook/tests/test_columns.py ...........                                                                [ 31%]
resources/home/dnanexus/generate_workbook/tests/test_filters.py .......                                                                    [ 51%]
resources/home/dnanexus/generate_workbook/tests/test_utils.py ........                                                                     [ 74%]
resources/home/dnanexus/generate_workbook/tests/test_vcf.py .........                                                                      [100%]

============================================================== 35 passed in 28.34s ===============================================================

This change is Reviewable

pep8speaks commented 2 years ago

Hello @jethror1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 382:28: W605 invalid escape sequence '\d' Line 382:32: W605 invalid escape sequence '\d'

Line 33:5: E303 too many blank lines (2) Line 48:5: E303 too many blank lines (2) Line 63:5: E303 too many blank lines (2)

Line 509:5: E303 too many blank lines (2)

Comment last updated at 2022-08-08 16:19:07 UTC