Closed kjwinfield closed 1 year ago
Hello @kjwinfield! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Line 362:80: E501 line too long (83 > 79 characters)
Line 50:80: E501 line too long (93 > 79 characters) Line 51:80: E501 line too long (93 > 79 characters)
Summary
DECIPHER link
DECIPHER is a database of rare disease variants (https://www.deciphergenomics.org/). This update adds a link to the variant page in DECIPHER for variants reported in the workbooks. An extra column is added when the
--decipher
input is specified. This column is populated with links to the variant in DECIPHER. These links are only generated for build 38 variants, as DECIPHER only stores build 38 dataExample output:![DECIPHER column with links added to spreadsheet](https://user-images.githubusercontent.com/71272357/184657880-6ad3610c-a64c-4da3-b76b-a23b8f8a6fbf.png)
Testing on DNAnexus
This version of the app was build as an applet on DNAnexus to test. In this project: 004_220720_eggd_generate_variant_workbook_v2.2.0_testing:/decipher_link the input .vcf and applet can be found.
A job was run with and without the
--decipher
inputwith --decipher input
Job ID: job-GFyKG6042Zj7b71g4gYY2bZY Output excel file:![Screenshot from 2022-08-17 14-19-20](https://user-images.githubusercontent.com/71272357/185147742-19a03048-3e2a-4d89-bf38-ef5ac1354a69.png)
without --decipher input
Job ID: job-GFyKf9Q42Zj47j2B4x2ZJ1fb Output excel file:![Screenshot from 2022-08-17 14-29-23](https://user-images.githubusercontent.com/71272357/185147723-b1173df6-974e-4c17-89d8-3d6ce906faae.png)
Tests
Tests have been added to the tests.vcf file to test:
--decipher
input is givenUnit tests
This change is![Reviewable](https://reviewable.io/review_button.svg)