search

eastgenomics / eggd_generate_variant_workbook

DNAnexus app for generating xlsx variant workbooks
3 stars 0 forks source link

Long URLs break excel #92

Closed mattgarner closed 2 years ago

mattgarner commented 2 years ago

Formulas cannot contain strings >255 chars in excel. Any formula containing these long strings are deleted when the file is opened.

This means that for variants with a long REF/ALT, the URL and the value are missing from the excel cell.

Perhaps don't include a link but just keep the value if the URL string len > 255 chars.

mattgarner commented 2 years ago

There is already a check for this at line 478, but gnomad does not get checked since the value is returned beforehand at 459:

https://github.com/eastgenomics/eggd_generate_workbook/blob/208a2c01962d8894426edd5c2f2a4dc8b634ace8/resources/home/dnanexus/generate_workbook/utils/vcf.py#L450-L488