Closed Yu-jinKim closed 2 weeks ago
Hello @Yu-jinKim! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
trendyqc/trend_monitoring/backend_utils/plot.py
:Line 187:80: E501 line too long (83 > 79 characters) Line 194:80: E501 line too long (81 > 79 characters) Line 311:80: E501 line too long (155 > 79 characters) Line 313:80: E501 line too long (155 > 79 characters) Line 314:80: E501 line too long (155 > 79 characters) Line 315:80: E501 line too long (155 > 79 characters) Line 316:80: E501 line too long (155 > 79 characters) Line 440:80: E501 line too long (87 > 79 characters)
trendyqc/trend_monitoring/views.py
:Line 320:80: E501 line too long (84 > 79 characters)
Coloring by group (assay sequencer id)
Coloring by sequencer id
Grouping by assay
Couldn't actually trigger the error message because i can cover all possible groups with the amount of colors i have right now. Will check when i do the unittesting
Closes #92 Closes #94
Backend
get_data_for_plotting
:get_metric_filter
:read_data
aka fastqc orbase_distribution
is detected for lane purposesformat_data_for_plotly_js
:create_trace
:get_date_from_project_name
:calculate_mean_across_columns
:apply
)Models
base_distribution
Template
plot
:This change is![Reviewable](https://reviewable.io/review_button.svg)