search

eastlakehs / community-service-tracker

Repo for the eastlake community service tracker website.
https://ehs-service.org
MIT License
4 stars 1 forks source link

Changed submit/edit page layout #170 #182

Closed TimofeiK27 closed 3 years ago

TimofeiK27 commented 3 years ago

Made the submit/edit page fit on the screen (no scrolling). Kept mobile UI.

netlify[bot] commented 3 years ago

This link represents the deploy preview for this given pr.

Building with commit 34fd2e4e81b4177758f6f5a600a853832ead6d41

https://app.netlify.com/sites/ehs-service/deploys/609b17c1dc45eb000796e504

TimofeiK27 commented 3 years ago

@daniel-sudz I used Visual Studio. I just downloaded Visual Studio Web Development (I hope that's the right thing). I ran the command "yarn format-write" in the root, so I hope it's going to work now!

TimofeiK27 commented 3 years ago

@daniel-sudz Do I just make a new pull request with the new code?

Zjjc123 commented 3 years ago

@daniel-sudz Do I just make a new pull request with the new code?

Just add more commits to your branch and it should automatically update the PR. Sorry I have been super busy recently havent had the time to look at the pr

daniel-sudz commented 3 years ago

@TimofeiK27 one more thing: it looks like you pulled in .vs/slnx.sqlite which is something specific to visual studio. Could you delete it from the PR and add .vs to the .gitignore at the root of the repo so it doesn't get added back in?

Zjjc123 commented 3 years ago

Also did you run yarn in the root folder? I don't think you need to do that right @daniel-sudz. there are a bunch of new dependencies in the root folder

TimofeiK27 commented 3 years ago

@Zjjc123 Ya sorry about that. Can I just revert the yarn file to its previous state?

Zjjc123 commented 3 years ago

@Zjjc123 Ya sorry about that. Can I just revert the yarn file to its previous state?

Yup that works!

TimofeiK27 commented 3 years ago

@Zjjc123 Hopefully it works now🙏