search

eastlakehs / community-service-tracker

Repo for the eastlake community service tracker website.
https://ehs-service.org
MIT License
4 stars 1 forks source link

Update production workflow to use nodejs 14 #214

Closed theTisch21 closed 2 years ago

theTisch21 commented 2 years ago

This pull request:

- Updates the production workflow to force it to use NodeJS 14 - Updates the testing workflow to force it to use NodeJS 14 ## Context:

When pushing some dependancy updates, the workflow to deploy to firebase failed, as the workflow runner by default had nodejs 16. Yarn was expecting version 14. This pull requests adds a setup-node action to force the nodejs version to 14.

After this PR is merged:

I will go back to the dependabot PRs, including #213 #212 and #211 and re-run the workflows, which will then accurately run the tests with nodejs 14.

netlify[bot] commented 2 years ago

👷 This link represents the deploy preview for this given pr.

🔨 Explore the source changes: 00b328776349f123db62644d6023ba539c1e41c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/ehs-service/deploys/61f05464c1cc3000080e7836

daniel-sudz commented 2 years ago

@theTisch21 sorry just saw this now. Was yarn failing the only problem here for node16? I think you could get by with just regenerating the lock files on node16.

I think firebase functions also have a node version target implicitly. We should explicitly declare it to prevent these kinds of problems. I think they might be dropping node14 as well soon.

It's not yarn erroring it's the engine constraint on firebase functions for https://github.com/eastlakehs/community-service-tracker/blob/master/firebase/functions/package.json#L13. We could probably update it sometime.

Explicitly declaring the version on workflow runner is a good idea anyways like you did.