easy-cloud / EasyACL

Zend and Doctrine ACL Module
9 stars 7 forks source link

PSR 0, 1 and 2 compliance... #1

Open vpassapera opened 11 years ago

vpassapera commented 11 years ago

I noticed in certain areas (https://github.com/easy-cloud/acl/blob/master/src/Controller/GroupController.php first place I looked....) you are not following all the PSR standards. While it is not required, it is recommended if you seek adoption in enterprise projects. (Just my two cents).

tawfekov commented 11 years ago

and could you please provide some tests . thanks

TNAJanssen commented 11 years ago

Sorry for my late reaction(was busy), i'm working on a couple of other modules and afterwards i will improve this one. I build this module in less then a week so it can be that there are some errors or missing standards.

I also made this project open so that other people can help me with improving it further.

TNAJanssen commented 11 years ago

PSR-0 - Done