search

easy-webpack / core

An easy way to create configuration files for Webpack
MIT License
68 stars 6 forks source link

Update WebpackConfig typings to include performance options (or migrate to @typings/webpack) #29

Open mdurling opened 7 years ago

mdurling commented 7 years ago

Configuration @easy-webpack/core@2.0.1 does not support including webpack performance options (hints, maxAssetSize, etc.)

e.g. I should be able to disable asset size warnings with the following options. They performance object is not part of the EasyWebpackConfig type definition.

performance: {
  hints: false
}
niieani commented 7 years ago

You can override or add the necessary object to the config yourself. See the README on how to achieve that.

mdurling commented 7 years ago

@niieani I understand. I override objects all the time. Using TypeScript, however, the issue is that the performance configuration object is not part of the Webpack interface in the version of webpack.d.ts that's included with @easy-webpack/core ... I have worked around this by casting my config as EasyWebpackConfig, but I believe the new webpack performance options should be added to the d.ts file (or the @types/webpack package)

niieani commented 7 years ago

Ah, I see. I didn't understand you mean the typings are incorrect. Ok, I'll handle this.