search

easybill / zugferd-php

ZUGFeRD PHP SDK (Factur-X, XRechnung)
https://www.easybill.de
MIT License
77 stars 35 forks source link

Missing ExemptionReason in TradeTaxType #34

Closed thomaswacker closed 3 years ago

thomaswacker commented 3 years ago

In the file "FACTUR-X_EN16931_urn_un_unece_uncefact_data_standard_ReusableAggregateBusinessInformationEntity_100.xsd" there is a "ExemptionReason" in "TradeTaxType", that is missing in zugferd211/Model/TradeTax.php.

PATROMO commented 3 years ago

@thomaswacker we did not imply everything because it is not necessary. You can create a pull request at any time and help us to improve the software.

thomaswacker commented 3 years ago

Thanks. Its because mustang validator said:

A VAT Breakdown (BG-23) with the VAT Category code (BT-118) "Export outside the EU" shall have a VAT exemption reason code (BT-121), meaning "Export outside the EU" or the VAT exemption reason text (BT-120) "Export outside the EU" (or the equivalent standard text in another language).

Pull request will come soon.

PATROMO commented 3 years ago

The XSD said: <xs:element name="ExemptionReason" type="udt:TextType" minOccurs="0"/> minOccurs="0". This means that it is not necessarily required.

thomaswacker commented 3 years ago

Thanks for fast merge!