search

easybill / zugferd-php

ZUGFeRD PHP SDK (Factur-X, XRechnung)
https://www.easybill.de
MIT License
75 stars 35 forks source link

Minor update #64

Open guillaume-sainthillier opened 1 month ago

guillaume-sainthillier commented 1 month ago

improve code quality and CI workflows

BolZer commented 3 weeks ago

@guillaume-sainthillier Thank your for opening the PR. However the PR is quite large and some of the changes are... quite drastic. Why change the CI pipeline? And an minor update pr with about 4k lines removed :)? Maybe we can shrink the PR and split it into more PRs which are easier to review. Could you open a discussion in this repository for the CI-Pipeline changes? What are the benefits and so. :)

guillaume-sainthillier commented 3 weeks ago

Hello @BolZer, i've split this PR into 2 more by adding #65 and #66. Will rebase this branch once you decide to merge them (or not).

Thanks, Guillaume

BolZer commented 2 weeks ago

Hello @BolZer, i've split this PR into 2 more by adding #65 and #66. Will rebase this branch once you decide to merge them (or not).

Thanks, Guillaume

Thanks @guillaume-sainthillier. That's much better to understand. We'll continue the discussion in the remaining PRs. The PR with the PHPStan modifications is already merged. Thank you :)