search

easybotics / node-rpi-rgb-led-matrix

Pilot your rgb led matrix with Nodejs ! Nodejs binding of rpi-rgb-led-matrix library https://github.com/hzeller/rpi-rgb-led-matrix - Actively Maintained!
Do What The F*ck You Want To Public License
57 stars 17 forks source link

Build fails if your node binary isn't called nodejs #1

Closed jonaslund closed 5 years ago

jonaslund commented 5 years ago

Easily fixed by changing this line in binding.gyp "include_dirs": [ "./external/matrix/include", "./include/", "<!(nodejs -e \"require('nan')\")" ]

Should be fixed

keptan commented 5 years ago

thanks ill look into this

redandinvisible commented 5 years ago

I am having the same problem. Is there a workaround by any chance?

redandinvisible commented 5 years ago

In case it helps others:

I cloned this repo and made it a local dependency. Then I changed the line in the local binding.gyp so the node binary was just called node. Tried npm install again which gave a new error make: *** No rule to make target `Release/obj.target/rpi-rgb-led-matrix/external/matrix/lib/transformer.o', needed by `Release/rpi-rgb-led-matrix.a'..

Turns out this was caused by some clever cross-github linking in the external directory to this "rpi-rgb-led-matrix" github repo. So I cloned the contents of that repo into the external directory. Removed the uneeded .git directories. And it now builds.

samturner3 commented 5 years ago

+1 Screen Shot 2019-05-28 at 3 17 38 pm

keptan commented 5 years ago

@redandinvisible the second half of your issue is just a matter of checking out submodules, I should make that clearer in the readme probably when you pull from npm this isn't an issue

still haven't changed the binding.gyp sorry

keptan commented 5 years ago

https://github.com/easybotics/node-rpi-rgb-led-matrix/commit/e4bae0bc62e05c34663e9733c5dba07a27ffaf33

finally dealing with this