search

easybotics / node-rpi-rgb-led-matrix

Pilot your rgb led matrix with Nodejs ! Nodejs binding of rpi-rgb-led-matrix library https://github.com/hzeller/rpi-rgb-led-matrix - Actively Maintained!
Do What The F*ck You Want To Public License
57 stars 17 forks source link

Fix constructor argument sequence #11

Closed lehni closed 3 years ago

lehni commented 4 years ago

parallel_displays and chained_displays are flipped around…

camow7 commented 4 years ago

This one stumped me initially as well and needs to be fixed. The PR should be merged however it will create breaking changes for anyone that has switched the args in their source to make it work.

ryanmich251 commented 3 years ago

To not break existing code, I think the argument sequence should just be swapped in the README so we're not giving people the wrong info on how to use the library. Also the variable names in the LedMatrix::New function should be swapped so all the code's consistent. I'll work on this.

ryanmich251 commented 3 years ago

Should be fixed with ce80bf2.