Explicitly call `csh` in custom easyblock for WPS

easybuilders / easybuild-easyblocks

Collection of easyblocks that implement support for building and installing software with EasyBuild.

https://easybuild.io

GNU General Public License v2.0

106 stars 285 forks source link

Explicitly call `csh` in custom easyblock for WPS #3384

Closed thanghn90 closed 3 months ago

thanghn90 commented 4 months ago

For system that doesn't have csh installed, /bin/csh won't call into the csh provided by tcsh module (if loaded as a build dependency). Tested and confirmed working on a Rocky 9 Haswell server.

boegel commented 3 months ago

@boegelbot please test @ generoso EB_ARGS="WPS-3.9.1-foss-2020b-dmpar.eb WPS-4.3.1-foss-2021a-dmpar.eb WPS-4.4-foss-2022a-dmpar.eb"

boegelbot commented 3 months ago

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3384 EB_ARGS="WPS-3.9.1-foss-2020b-dmpar.eb WPS-4.3.1-foss-2021a-dmpar.eb WPS-4.4-foss-2022a-dmpar.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3384 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:
```
Submitted batch job 13980
```

Test results coming soon (I hope)...

*- notification for comment with ID 2260599653 processed* *Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).*

boegelbot commented 3 months ago

Test report by @boegelbot

Overview of tested easyconfigs (in order)

SUCCESS WPS-3.9.1-foss-2020b-dmpar.eb
SUCCESS WPS-4.3.1-foss-2021a-dmpar.eb
SUCCESS WPS-4.4-foss-2022a-dmpar.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total) cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/boegelbot/37502d1bd1b135f50f6c016f2f9541b2 for a full test report.