easybuilders / easybuild-easyblocks

Collection of easyblocks that implement support for building and installing software with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
106 stars 285 forks source link

Set `DEFCUDAVERSION` and `DEFSTDPARCOMPUTECAP` correctly in localrc for NVHPC #3387

Open damianam opened 4 months ago

damianam commented 4 months ago

Without these changes those variables are not defined correctly. Example of the resulting difference:

-set DEFCUDAVERSION=12.3;
-set DEFSTDPARCOMPUTECAP=;
+set DEFCUDAVERSION=12;
+set DEFSTDPARCOMPUTECAP=80;
boegel commented 3 months ago

@boegelbot please test @ jsc-zen3 EB_ARGS="NVHPC-21.9.eb NVHPC-24.1-CUDA-12.3.0.eb"

boegelbot commented 3 months ago

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3387 EB_ARGS="NVHPC-21.9.eb NVHPC-24.1-CUDA-12.3.0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3387 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

Test results coming soon (I hope)...

*- notification for comment with ID 2260646726 processed* *Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).*
boegelbot commented 3 months ago

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 2 (2 easyconfigs in total) jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18 See https://gist.github.com/boegelbot/c7365d7b690e1692e61bc6e4a31675d1 for a full test report.