search

easybuilders / easybuild-easyblocks

Collection of easyblocks that implement support for building and installing software with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
106 stars 285 forks source link

fix extra `$PATH` entry for OCaml to use `opam/default` rather than `opam/system` #3390

Closed branfosj closed 3 months ago

branfosj commented 4 months ago

For OCaml/5.1.1-GCC-13.2.0 on generoso and for OCaml/4.14.0-GCC-11.3.0 on my system there is no opam/system but there is opam/default and this contains ocamlfind

branfosj commented 4 months ago

Test report by @branfosj

Overview of tested easyconfigs (in order)

Build succeeded for 1 out of 1 (1 easyconfigs in total) bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8 See https://gist.github.com/branfosj/9feae9561a08c50ad07a052e3d42079b for a full test report.

branfosj commented 3 months ago

@branfosj Let's add "ocamlfind list" as sanity check command to catch this bug?

Maybe that should only be done conditionally though, when ocamlfind is being installed as extension?

Done in bc7fa88.

boegel commented 3 months ago

@boegelbot please test @ jsc-zen3 EB_ARGS="OCaml-4.14.0-GCC-11.3.0.eb OCaml-5.1.1-GCC-13.2.0.eb"

boegelbot commented 3 months ago

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3390 EB_ARGS="OCaml-4.14.0-GCC-11.3.0.eb OCaml-5.1.1-GCC-13.2.0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3390 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

Test results coming soon (I hope)...

*- notification for comment with ID 2287170284 processed* *Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).*
boegelbot commented 3 months ago

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 2 out of 2 (2 easyconfigs in total) jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18 See https://gist.github.com/boegelbot/39d7551c0796de6ab8a6b2c6f0bdf8c7 for a full test report.