search

easybuilders / easybuild-easyblocks

Collection of easyblocks that implement support for building and installing software with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
106 stars 285 forks source link

OpenFOAM v2406 is built without cfMesh package #3421

Closed furstj closed 2 months ago

furstj commented 2 months ago

The ESI version of OpenFoam v2406 is built without cfMesh plugin. The cfMesh package was in modules directory up to v2312, but now ESI moved it to plugins. The procedure described in plugins/README.md does not work due to missing .git directory.

Reproduce:

eb -r OpenFOAM-v2406-foss-2023b.eb
cartesianMesh

This gives 'Command not found'

The information in plugins/README.md:

  cd $WM_PROJECT_DIR
  git submodule update --init --recursive

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
boegel commented 2 months ago

Hmm, this probably means we'll need to download the sources for OpenFOAM v2406 via git_config?

@WilleBell Is this something you're up for looking into, since you contributed the easyconfig for OpenFOAM v2406 in #21036?

furstj commented 2 months ago

There is an additional archive in https://dl.openfoam.com/source/latest/. In the current version (v2406) ESI has three source archives:

It seems that "modules" are included in main archive, i.e. in OpenFOAM-v2406.tgz but "pugins" are not. May be that someone can modify the openfoam.py easyblock to (optionally?) download and install OpenFOAM-plugins-v2406.tgz.

WilleBell commented 2 months ago

Hmm, this probably means we'll need to download the sources for OpenFOAM v2406 via git_config?

@WilleBell Is this something you're up for looking into, since you contributed the easyconfig for OpenFOAM v2406 in #21036?

Sure, I can look into it.

branfosj commented 2 months ago

https://github.com/easybuilders/easybuild-easyconfigs/pull/21332 unpacks the plugins ontop of the OF directory. I currently have this test building, so I do not yet know if anything else is needed to fix the issue here.

branfosj commented 2 months ago

easyblock change to build the plugins: https://github.com/easybuilders/easybuild-easyblocks/pull/3436

Can you check your build logs and see if there are these two in several times?

The first is also in our v2306 and v2312 builds. The second has been in builds since at least v1906. Do we need to fix either?