easybuilders / easybuild-easyblocks

Collection of easyblocks that implement support for building and installing software with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
106 stars 285 forks source link

enhance binutils easyblock to explicitely pass msgpack configure option #3438

Closed Flamefire closed 2 months ago

Flamefire commented 2 months ago

(created using eb --new-pr)

This avoids an error when using readelf when msgpack was installed on the system during configure but is not available at runtime on the node where it is used:

readelf: error while loading shared libraries: libmsgpackc.so.2: cannot open shared object file: No such file or directory

We have "msgpack-c" EasyConfigs which could be used, so add a check for that but error out if used prior to where the support in binutils was introduced: https://github.com/bminor/binutils-gdb/commit/2952f10cd79af4645222f124f28c7928287d8113

Flamefire commented 2 months ago

Test report by @Flamefire

Overview of tested easyconfigs (in order)

Build succeeded for 2 out of 2 (2 easyconfigs in total) login1 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17 See https://gist.github.com/Flamefire/f8839435528434c6394d0b2cbaf1a078 for a full test report.

Flamefire commented 2 months ago

Test report by @Flamefire

Overview of tested easyconfigs (in order)

Build succeeded for 8 out of 8 (8 easyconfigs in total) login2.romeo.hpc.tu-dresden.de - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17 See https://gist.github.com/Flamefire/a7ad7c48761c26622398e8e602424f72 for a full test report.

boegel commented 2 months ago

@boegelbot please test @ generoso EB_ARGS="binutils-2.37.eb binutils-2.38-GCCcore-11.3.0.eb binutils-2.39.eb binutils-2.39-GCCcore-12.2.0.eb binutils-2.42-GCCcore-13.3.0.eb binutils-2.42.eb --installpath /tmp/$USER/pr3438"

boegelbot commented 2 months ago

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3438 EB_ARGS="binutils-2.37.eb binutils-2.38-GCCcore-11.3.0.eb binutils-2.39.eb binutils-2.39-GCCcore-12.2.0.eb binutils-2.42-GCCcore-13.3.0.eb binutils-2.42.eb --installpath /tmp/$USER/pr3438" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3438 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

Test results coming soon (I hope)...

*- notification for comment with ID 2342810032 processed* *Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).*
boegelbot commented 2 months ago

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 6 out of 6 (6 easyconfigs in total) cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/boegelbot/658191c43e9f2dd256e57a24accc89fd for a full test report.