easybuilders / easybuild-easyblocks

Collection of easyblocks that implement support for building and installing software with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
106 stars 285 forks source link

fix setting of `CMAKE_OPTIONS` for SuiteSparse versions between 5.1.2 and 6.0.0 #3471

Closed boegel closed 1 week ago

boegel commented 1 month ago

(created using eb --new-pr)

fix for failure when installing SuiteSparse-5.13.0-foss-2022a-METIS-5.1.0.eb:

CMake Error at cmake_install.cmake:57 (file):
  file INSTALL cannot copy file
  "/tmp/vsc40023/easybuild_build/SuiteSparse/5.13.0/foss-2022a-METIS-5.1.0/SuiteSparse-5.13.0/GraphBLAS/build/libgraphblas.so.7.2.0"
  to "/usr/local/lib64/libgraphblas.so.7.2.0": Permission denied.

This issue occurs because CMAKE_INSTALL_PREFIX is set by CMAKE_OPTIONS, but it's not getting pass to the make install command correctly...

I'm a bit confused as to why this didn't pop up in the test report for #3004, but maybe the subsequent changes in #3031 have something to do with it...

boegel commented 1 month ago

@boegelbot please test @ generoso EB_ARGS="SuiteSparse-5.7.1-foss-2020a-METIS-5.1.0.eb SuiteSparse-5.8.1-foss-2020b-METIS-5.1.0.eb SuiteSparse-5.10.1-foss-2021a-METIS-5.1.0.eb SuiteSparse-5.10.1-foss-2021b-METIS-5.1.0.eb SuiteSparse-5.10.1-intel-2021a-METIS-5.1.0.eb SuiteSparse-5.10.1-intel-2021b-METIS-5.1.0.eb SuiteSparse-5.13.0-foss-2022a-METIS-5.1.0.eb SuiteSparse-5.13.0-foss-2022b-METIS-5.1.0.eb --installpath /tmp/$USER/pr3471" CORE_CNT=16

boegelbot commented 1 month ago

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3471 EB_ARGS="SuiteSparse-5.7.1-foss-2020a-METIS-5.1.0.eb SuiteSparse-5.8.1-foss-2020b-METIS-5.1.0.eb SuiteSparse-5.10.1-foss-2021a-METIS-5.1.0.eb SuiteSparse-5.10.1-foss-2021b-METIS-5.1.0.eb SuiteSparse-5.10.1-intel-2021a-METIS-5.1.0.eb SuiteSparse-5.10.1-intel-2021b-METIS-5.1.0.eb SuiteSparse-5.13.0-foss-2022a-METIS-5.1.0.eb SuiteSparse-5.13.0-foss-2022b-METIS-5.1.0.eb --installpath /tmp/$USER/pr3471" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3471 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

Test results coming soon (I hope)...

*- notification for comment with ID 2395530592 processed* *Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).*
boegelbot commented 1 month ago

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 8 out of 8 (8 easyconfigs in total) cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/boegelbot/2890a99dfa378983b6775dda4cb409d2 for a full test report.

lexming commented 1 week ago

Merging, thanks @boegel !