search

easybuilders / easybuild-easyblocks

Collection of easyblocks that implement support for building and installing software with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
106 stars 283 forks source link

the tarball easyblock should check how the result looks like (recursive? #51

Closed JensTimmerman closed 11 years ago

JensTimmerman commented 12 years ago

if the result of unpacking a gz file is a tar file easybuild should go ahead and unpack that again...

fgeorgatos commented 11 years ago

an easy solution, for now, is to provide a variable that forces the recognition of the format to a particular one (ie. supply .tar.gz as format in the abinit case)

boegel commented 11 years ago

This would be quite complex to implement imho, and potentially yield a lot of overhead during unpacking.

Should we try and fix the errors that other people make when creating zipped tarballs? I don't feel we should.

A workaround for this is suggested in https://github.com/hpcugent/easybuild-framework/pull/377 .

BTW: this issue should have been created in easybuild-framework. ;-)

Do you guys agree that adding support for explicitly specifying the extract command is a suitable workaround for this? Can we close this issue as wontfix?

JensTimmerman commented 11 years ago

Well, I think we should try to fix errors that other people make, since this is the whole point of easybuild :-p But making it configurable in the easyconfig is good enough yes.

boegel commented 11 years ago

I'll close this, since I consider this fixed (albeit in another way).

@fgeorgatos: Do let us know if you disagree with this being closed.

fgeorgatos commented 11 years ago

all good: we have a generic solution to handle the family of such issues and that is exactly what matters.