Closed terjekv closed 4 years ago
If the function is supposed to have linkage, the static
on line 36 is erroneous and should be removed, matching the definition in the #else
branch.
Well, the blocks around https://github.com/vdorie/dbarts/blob/178427773db82df75787dacbcc609b00f213248f/src/misc/simd.c#L54 may also cause some issues on arm and power? I also spy immintrin.h
which does SSE intrinsics, so we're back to https://github.com/DLTcollab/sse2neon/blob/master/sse2neon.h and friends. @boegel, should darts
be taken out of R and made into its own Rpackage so we can debug this later[tm]?
The preprocessor branch you're talking about there is for x86 and x64 only. It doesn't end until https://github.com/vdorie/dbarts/blob/178427773db82df75787dacbcc609b00f213248f/src/misc/simd.c#L190
The fix is trivial: https://gist.github.com/zao/1ecfec2e52a6fe7cb3e17a9ac407c0a1 With this patch it builds with my system R on Ubuntu 20.04. Give it a try.
Also filed an issue with upstream: https://github.com/vdorie/dbarts/issues/35
The preprocessor branch you're talking about there is for x86 and x64 only. It doesn't end until https://github.com/vdorie/dbarts/blob/178427773db82df75787dacbcc609b00f213248f/src/misc/simd.c#L190
Oh whow, I completely misread the scope. That's what I get for not dumping the file into an editor.
The fix is trivial: https://gist.github.com/zao/1ecfec2e52a6fe7cb3e17a9ac407c0a1 With this patch it builds with my system R on Ubuntu 20.04. Give it a try.
I'll give it a whirl! Thanks!
Thanks. The patch means that dbarts builds fine on POWER.
Same, works on arm as well. I'll make a PR.
https://github.com/easybuilders/easybuild-easyconfigs/commit/858f50f14f5eb7d7719b03594241955be2b5d7d2#diff-f2a7ccd2712a57d5dff6f0bd478d7d18 (via ##11430)) breaks on arm: https://gist.github.com/terjekv/1c98b51b2f5b3b85ef33e3be08c7f3f5