libjxl easyconfig fails to install if asciidoc is installed in OS

easybuilders / easybuild-easyconfigs

A collection of easyconfig files that describe which software to build using which build options with EasyBuild.

https://easybuild.io

GNU General Public License v2.0

380 stars 702 forks source link

libjxl easyconfig fails to install if asciidoc is installed in OS #13827

Closed boegel closed 3 years ago

boegel commented 3 years ago

libjxl added in #13453 fails for me with:

  File "/usr/bin/a2x", line 76
    print '%s: %s' % (PROG,msg)
                 ^
SyntaxError: invalid syntax

$ rpm -qf /usr/bin/a2x
asciidoc-8.6.8-5.el7.noarch

branfosj commented 3 years ago

CMake option: JPEGXL_ENABLE_MANPAGES=OFF

boegel commented 3 years ago

@branfosj Hmm, no?

CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_Fortran_COMPILER
    CMAKE_Fortran_FLAGS
    JPEGXL_ENABLE_MANPAGES

branfosj commented 3 years ago

Ah. They've added that option since 0.3.7. :(

It looks like it will need patching out: https://github.com/libjxl/libjxl/blob/9e9bce86164dc4d01c39eeeb3404d6aed85137b2/CMakeLists.txt#L287

Or adding asciidoc as a build dependency.

Micket commented 3 years ago

We could look to update libjxl as well (they released it just after i made the PR)

boegel commented 3 years ago

I looked into asciidoc once, it was... messy.

So bumping to libjxl 0.5 and using -DJPEGXL_ENABLE_MANPAGES=OFF then?

branfosj commented 3 years ago

Yes, bump libjxl to 0.5.