search

easybuilders / easybuild-easyconfigs

A collection of easyconfig files that describe which software to build using which build options with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
380 stars 703 forks source link

Mistake in GPAW-20.1.0-Add-Easybuild-configuration-files.patch #14598

Closed dithwick closed 2 years ago

dithwick commented 2 years ago

Hi,

We've spotted a mistake in GPAW-20.1.0-Add-Easybuild-configuration-files.patch which is only apparent if you are doing a foss build of GPAW and add ELPA. Line 27 of https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/g/GPAW/GPAW-20.1.0-Add-Easybuild-configuration-files.patch has:

@@ -0,0 +1,49 @@

However this results in a truncated patch that ends at:

+    library_dirs.append(os.path.join(elpa, 'lib'))
+    extra_link_args += ['-Wl,-rpath={}/lib'.format(elpa)]

and doesn't add the modified include paths. There is a quick fix of changing the line to

@@ -0,0 +1,53 @@

and adjusting the checksum accordingly (worked for me) but wasn't sure if there's a quick way of updating the patch and the checksums in the easyconfig repo.

boegel commented 2 years ago

Looks like this slipped in with #11523, where the patch was manually edited by @surak...

boegel commented 2 years ago

@dithwick This problem is fixed in #14619

surak commented 2 years ago

sorry for that, it was what came out of "eb --inject-checksums"...

boegel commented 2 years ago

@surak It's the patch file itself that was broken, essentially.