easybuilders / easybuild-easyconfigs

A collection of easyconfig files that describe which software to build using which build options with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
356 stars 685 forks source link

add patch to fix build error with numpy with some compilers #20817

Closed Flamefire closed 1 week ago

Flamefire commented 1 week ago

NumPy doesn't need Fortran for building but still initializes the Fortran compiler which fails when the compiler requires a different commandline argument than GCC, e.g. the Fujitsu compiler. Failure message starts with

A valid Fortran version was not found in this string:

See https://github.com/easybuilders/easybuild-easyblocks/issues/2518 Patch is from https://github.com/numpy/numpy/pull/26502 which won't get merged but isn't necessary in numpy 1.26+

CC @migueldiascosta

smoors commented 1 week ago

@boegelbot: please test @ generoso

boegelbot commented 1 week ago

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=20817 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20817 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

Test results coming soon (I hope)...

*- notification for comment with ID 2167844287 processed* *Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).*
Flamefire commented 1 week ago

Test report by @Flamefire SUCCESS Build succeeded for 13 out of 13 (13 easyconfigs in total) n1615 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13 See https://gist.github.com/Flamefire/a2a7e14bdc09484629fc23ca1b6f6fae for a full test report.

boegelbot commented 1 week ago

Test report by @boegelbot SUCCESS Build succeeded for 13 out of 13 (13 easyconfigs in total) cns4 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/boegelbot/dc5e5b3d19d763b6e870e2aa3ee06195 for a full test report.

smoors commented 1 week ago

@boegelbot please test @ jsc-zen3 CORE_CNT=16

boegelbot commented 1 week ago

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20817 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20817 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

Test results coming soon (I hope)...

*- notification for comment with ID 2169183633 processed* *Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).*
boegelbot commented 1 week ago

Test report by @boegelbot FAILED Build succeeded for 16 out of 22 (13 easyconfigs in total) jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18 See https://gist.github.com/boegelbot/2ad78fb9e36528b0e56ffe28cb400a80 for a full test report.

branfosj commented 1 week ago

Test report by @branfosj SUCCESS Build succeeded for 15 out of 15 (13 easyconfigs in total) bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8 See https://gist.github.com/branfosj/a998035d2f977f8d296431119b541535 for a full test report.

branfosj commented 1 week ago

Going in, thanks @Flamefire!