easybuilders / easybuild-easyconfigs

A collection of easyconfig files that describe which software to build using which build options with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
356 stars 685 forks source link

sync with develop (20240619) #20851

Closed boegel closed 5 days ago

boegel commented 1 week ago

🤔

ERROR: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 938, in test_dep_versions_per_toolchain_generation
    for ec in self.ordered_specs:
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 281, in ordered_specs
    EasyConfigTest.resolve_all_dependencies()
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 213, in resolve_all_dependencies
    cls._parsed_easyconfigs, modules_tool(), retain_all_deps=True)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/robot.py", line 465, in resolve_dependencies
    raise_error_missing_deps(totally_missing, extra_msg="no easyconfig file or existing module found")
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/robot.py", line 328, in raise_error_missing_deps
    raise EasyBuildError(error_msg)
easybuild.tools.build_log.EasyBuildError: 'Missing dependencies: rpmrebuild/2.11 (no easyconfig file or existing module found)'

======================================================================
FAIL: test__parse_easyconfig_PSIPRED-4.02-GCC-12.3.0.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for easyconfig PSIPRED-4.02-GCC-12.3.0.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1750, in innertest
    template_easyconfig_test(self, spec_path)
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1604, in template_easyconfig_test
    self.fail('Verification for %s failed:\n' % os.path.basename(spec) + '\n'.join(failing_checks))
AssertionError: Verification for PSIPRED-4.02-GCC-12.3.0.eb failed:
Patch file /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/p/PSIPRED/PSIPRED-4.02_fix_segfault.patch is missing

----------------------------------------------------------------------
Ran 9942 tests in 423.667s

FAILED (failures=1, errors=1)
Micket commented 1 week ago

https://github.com/easybuilders/easybuild-easyconfigs/pull/20513 reintroduced a builddep on rpmrebuild, which had gotten archived in 5.0.x

rpmbuild version 2.11 was released 2013, i think we should at the very least use an uptodate version.

https://github.com/easybuilders/easybuild-easyconfigs/pull/20861

you can merge/cherrypick this to fix it.

boegel commented 1 week ago

I've restored the missing patch from develop in 1c783b3930