easybuilders / easybuild-easyconfigs

A collection of easyconfig files that describe which software to build using which build options with EasyBuild.
https://easybuild.io
GNU General Public License v2.0
366 stars 698 forks source link

Ensure next release has PEP0008 compliance - at least for the obvious things #23

Closed fgeorgatos closed 11 years ago

fgeorgatos commented 11 years ago

This had been originally opened as https://github.com/hpcugent/easybuild-framework/issues/336

There are especially too many leftovers from the early days prototypes, whereby the rule on spacing is not adhered to; because newcomers have the valid habit of copy-pasting working examples, this seems to be a never-ending story. So, let's fix it in the next round.

Example of need to fix:

BEFORE:

name='BEAGLE'
version='20120124'

homepage='http://code.google.com/p/beagle-lib/'
description="""
BEAGLE is a high-performance library that can perform the core
calculations at the heart of most Bayesian and Maximum Likelihood
phylogenetics packages.
"""

toolchain={'name':'goalf','version':'1.1.0-no-OFED'}

sources=['%s-lib-%s.tgz'%(name.lower(),version)]

# There is no source tarball available, only SVN, see also README
source_urls=[]

# parallel build does not work
parallel=1

AFTER:

name = 'BEAGLE'                                                                                                                                                                    
version = '20120124'                                                                                                                                                               

homepage = 'http://code.google.com/p/beagle-lib/'                                                                                                                                  
description = """                                                                                                                                                                  
BEAGLE is a high-performance library that can perform the core                                                                                                                     
calculations at the heart of most Bayesian and Maximum Likelihood                                                                                                                  
phylogenetics packages.                                                                                                                                                            
"""                                                                                                                                                                                

toolchain = {'name': 'goalf', 'version': '1.1.0-no-OFED'}                                                                                                                          

sources = ['%s-lib-%s.tgz'%(name.lower(),version)]                                                                                                                                 

# There is no source tarball available, only SVN, see also README                                                                                                                  
source_urls = []                                                                                                                                                                   

# parallel build does not work                                                                                                                                                     
parallel = 1                                                                                                                                                                                                                                                                                                                                                      
boegel commented 11 years ago

Fixed by #24 and #58.