search

easybuilders / easybuild-framework

EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way.
https://easybuild.io
GNU General Public License v2.0
152 stars 202 forks source link

Don't use priority for module use #3631

Open Flamefire opened 3 years ago

Flamefire commented 3 years ago

See https://github.com/easybuilders/easybuild-framework/pull/3557, especially:

We have a function prepend_module_path with an optional priority. Hence if we don't pass a priority then this function will not "prepend" the path

Especially for LMod we should not use the priority at all. Instead we can simply implement use, unuse and prepend by modifying MODULEPATH as is done for use in #3557

Note: As a side-effect from #3557 prepend_module_path without a priority is already working as it should now.

boegel commented 3 years ago

@Flamefire Is this fixed with the changes in #3636? If so, can you add a fixes #3631 in the PR description there?

Flamefire commented 3 years ago

Yes and done