Open Flamefire opened 1 month ago
I just noticed that the SciPy-bundle module generated by --module-only is missing some paths.
SciPy-bundle
--module-only
Those are supposed to be added by the numpy extension. However the current mechanism is flawed:
numpy
ext.run()
The problems with this are:
--skip
--parallel-extension
From our "official" easyblocks only numpy uses that mechanism.
So we need a new method for extensions that returns the module-extra when used as an extension. The current make_module_extra cannot be used for that.
make_module_extra
I'd propose make_module_extra_extension but we already have make_module_extra_extensions which would be confusing.
make_module_extra_extension
make_module_extra_extensions
@boegel I'd also consider this a blocker for 5.x especially as it is pretty much impossible to fix this in a fully backwards compatible manner, see the PR: #4652
I just noticed that the
SciPy-bundle
module generated by--module-only
is missing some paths.Those are supposed to be added by the
numpy
extension. However the current mechanism is flawed:ext.run()
is collected in a variable: https://github.com/easybuilders/easybuild-framework/blob/bf0af10626644574cdf528998962b6f3c770fdc1/easybuild/framework/easyblock.py#L1950-L1952The problems with this are:
--module-only
this is not run--skip
it might not be run--parallel-extension
it is not used either: https://github.com/easybuilders/easybuild-framework/blob/bf0af10626644574cdf528998962b6f3c770fdc1/easybuild/framework/easyblock.py#L2014From our "official" easyblocks only
numpy
uses that mechanism.So we need a new method for extensions that returns the module-extra when used as an extension. The current
make_module_extra
cannot be used for that.I'd propose
make_module_extra_extension
but we already havemake_module_extra_extensions
which would be confusing.