search

easybuilders / easybuild

EasyBuild - building software with ease
http://easybuild.io
GNU General Public License v2.0
466 stars 143 forks source link

Bug: --job and --from-pr incompatible, tmpdir removed prematurely #889

Closed VRehnberg closed 6 months ago

VRehnberg commented 6 months ago

When running e.g. eb -r --from-pr=19987 --job the jobs will fail with messages like:

ERROR: Can't find path $EASYBUILD_TMPDIR/eb-xsck4mxp/files_pr19987/l/libmad/libmad-0.15.1b-GCCcore-12.3.0.eb

this is probably because the process launching the jobs finishes with:

== Submitted parallel build jobs, exiting now
== Temporary log file(s) $EASYBUILD_TMPDIR/eb-xsck4mxp/easybuild-bowmu2em.log* have been removed.
== Temporary directory $EASYBUILD_TMPDIR/eb-xsck4mxp has been removed.

Proposed solution

Have an extra job with dependency on all jobs finishing (ok or not) that removes the builds temporary directory and don't remove it as soon as jobs have been submitted.

akesandgren commented 6 months ago

The solution is to use --disable-cleanup-tmpdir and --tmpdir pointing to a not-per-job-temporary directory.

VRehnberg commented 6 months ago

Current behavior could be improved but existing solution is good enough for me. Closing.