Closed THEtomaso closed 2 years ago
https://github.com/easylist/easylist/commit/e7b54192e4bd7a70c0c29be9e88134cb94a5ee75
That only fixes the issue @ danica.no
, danicapension.dk
and danskeci.com
.
The rest of the sites are still broken, like before!
Instead of only adding whitelistings for the bare minimum of problem rules, why not include whitelistings for all of the problem rules, which I pointed out? This would fix the issues properly, and allow users to actually read up on the agreement terms, instead of just blindly having to accept them!
I must be blind, but I counted 8 domains in that one commit.
Yeah, but #@#.cookie-consent-banner
is not enough for danskebank.co.uk
, danskebank.com
, danskebank.dk
, danskebank.fi
, danskebank.no
and danskebank.se
!
What we already have; I'm not seeing issues currently
danskebank.*##+js(remove-class, cookie-consent-banner-open, html)
danica.no,danicapension.dk,danskebank.co.uk,danskebank.com,danskebank.dk,danskebank.fi,danskebank.no,danskebank.se,danskeci.com#@#.cookie-consent-banner
From my end, the sites are still broken, because of this rule (which you need to remove):
danskebank.*##.cookie-consent-banner-modal
@DandelionSprout; Could you please confirm this, from your location?
Preferably, this rule should be whitelisted too:
###cookie-text
..in order to allow users to read up on the cookie terms.
After testing with EasyList Cookie on and the IDCAC extension off, I am sorry to say that I can't seem to reproduce this in Chrome.
Thanks for testing, DS. I've found the problem..
This rule does NOT work in uBO Legacy!:
danskebank.*##+js(rc, cookie-consent-banner-open, html)
It needs to be like this:
danskebank.*##+js(remove-class.js, cookie-consent-banner-open, html)
But what about people using ABP-based blockers?
danskebank.*##.cookie-consent-banner-modal
will still break the sites for them!
..or is that rule excluded for them?
--
EDIT1: @JustOff: Not working as intended?: https://github.com/gorhill/uBlock-for-firefox-legacy/blob/master/src/js/assets.js#L363 ..or is the syntax converter simply not enabled for Easylist Cookie List? EDIT2: Not enabled, it would seem: https://github.com/gorhill/uBlock-for-firefox-legacy/blob/master/assets/assets.json#L202 @ryanbr: I guess it needs to be enabled for all of Fanboy's filters now then, and for EasyList as well?
This rule does NOT work in uBO Legacy!:
does not work only in "My filters" (use the full name for tests) in other filters it works - it is automatically converted https://github.com/gorhill/uBlock-for-firefox-legacy/blob/master/src/js/assets.js#L363
I had to edit and repack uBO Legacy --> assets.js (delete or set false the line "noConvert": true,
)
@AroKol78: Look at the edits, in my previous post.
@okiehsch: Until these issues have been sorted out, could you add the rules that I posted here (under "Possible fix") to uBlock filters - Legacy?: https://github.com/AdguardTeam/AdguardFilters/issues/102909#issuecomment-992330510
I didn't get an answer to my question here: https://github.com/easylist/easylist/issues/10035#issuecomment-994794684 ..which was "what about people using ABP-based blockers?".
They don't take advantage of the uBO-specific ##+js
rule.
Therefore, this remaining problem rule still breaks the sites for them!:
danskebank.*##.cookie-consent-banner-modal
Right?
Also, this rule still prevents users from reading the cookie terms:
###cookie-text
Easylist Cookie List already allows it for the .fi
domain, with this rule:
danskebank.fi#@##cookie-text
It should be changed into this:
danica.no,danicapension.dk,danskebank.co.uk,danskebank.com,danskebank.dk,danskebank.fi,danskebank.no,danskebank.se,danskeci.com#@##cookie-text
Full info here: https://github.com/AdguardTeam/AdguardFilters/issues/102909#issuecomment-992330510