easylist / easylist

EasyList filter subscription (EasyList, EasyPrivacy, EasyList Cookie, Fanboy's Social/Annoyances/Notifications Blocking List)
https://easylist.to
2.21k stars 715 forks source link

kemono.su, coomer.su #18325

Open ambigravity opened 8 months ago

ambigravity commented 8 months ago

Previous relevant issue: #18275

(Hopefully nobody will be rude in this one…)

Did some testing to see if the current whitelist is sufficient. Caught a few things that will need tweaking.

  1. There's an endpoint for flagging posts that needs whitelisting. URLs are of the following form:
    • https://{domain}/api/v1/{service_name}/user/{user_id}/post/{post_id}/flag
  2. User IDs can apparently contain letters and underscores (potentially more), not just purely numbers.
    • e.g. https://coomer.su/onlyfans/user/sweetiefox_of
    • These may also contain uppercase characters: https://kemono.su/dlsite/user/RG13809

Where:

In summary:

Should be noted: I reviewed the site, and it looks like the operator has removed all tracking from their site in response to previous filter changes. Visiting webpages under a variety of circumstances (logged in, logged out, incognito, adblock on, adblock off, etc.) show no POST or PATCH requests to tracking endpoints. Checking the site's forum, it looks like users have assumed the recent functionality regressions caused by this list were due to the operator breaking the site themselves, and the feedback has been… honestly rather horrible. Lots of abuse of the site operator in there.

Not sure how this list prefers to handle such scenarios, but I suspect the site operator realized that the rule evasion arms race does not end favourably for them, and have decided to drop tracking entirely. I'm unsure how we prefer to handle such situations, but we could avoid a good chunk of maintenance burden and user-side breakage potential by removing the filter rules for the site, given the change. I would volunteer to keep an eye on the site for a while to be sure it stays that way—it's not convenient for me, but I think that's the best outcome for everyone collectively. Maybe I'm not jaded enough yet, but there you go.

Anyway! Hope that's helpful.

Yuki2718 commented 8 months ago

Rules currently break the flagging endpoint; an entry in the whitelist is needed to correct this

I added

@@/^https:\/\/coomer\.su\/api\/v1\/(?:fansly|onlyfans)\/user\/[a-z]+\/post\/[0-9a-zA-Z]+\/flag$/$xhr,1p,match-case,method=post
@@/^https:\/\/kemono\.su\/api\/v1\/(?:afdian|boosty|discord|dlsite|fan(?:box|tia)|gumroad|onlyfans|patreon|subscribestar)\/user\/\d+\/post\/[0-9a-zA-Z]+\/flag$/$xhr,1p,match-case,method=post

and based on your description I don't see why they don't work except for another point of user ID which I will fix.

Yuki2718 commented 8 months ago

I'm also ready to relax {service_name} part, but if you can provide the full list of them this is the best. Not saying waste your time, but want to confirm at least one example not covered by the current rules before relaxing.

Daxy7 commented 8 months ago

@Yuki2718 flagging posts with an account:

https://kemono.su/api/v1/boosty/user/coffeesquirrel/post/660b6822-fc29-4152-9616-8947fbd1eb4f/flag

logger https://github.com/easylist/easylist/assets/91396482/3975042f-3d93-4f24-bee7-1015285bdb2d

posts' generated ID's can be this sequence as well

https://kemono.su/boosty/user/coffeesquirrel/post/660b6822-fc29-4152-9616-8947fbd1eb4f
https://kemono.su/boosty/user/coffeesquirrel/post/c35e1f75-fb77-4b7b-9bb5-431debb15a67
https://kemono.su/boosty/user/coffeesquirrel/post/d2abdcf1-43e7-4513-bbe6-2714f4a0c05b
Daxy7 commented 8 months ago

ad banner

https://coomer.su/
coomer.su##[href^="//a.adtng.com"]

https://github.com/easylist/easylist/assets/91396482/25cb05bf-b6fc-4216-9de3-9ef1c088b66b

https://github.com/easylist/easylist/blob/6fe4c7e07cffb22dd35a8b135f0f0cb9d2f3cddf/easylist/easylist_specific_hide.txt#L4513