search

easylist / easylist

EasyList filter subscription (EasyList, EasyPrivacy, EasyList Cookie, Fanboy's Social/Annoyances/Notifications Blocking List)
https://easylist.to
2.04k stars 686 forks source link

Fanboys Social doesn't actually work on uBO #19162

Closed Squall-Leonhart closed 4 weeks ago

Squall-Leonhart commented 4 weeks ago

Despite having uBO includes configured, the list isn't properly parsed resulting in 0 out of 0 filters used notice.

this goes back a couple of years https://github.com/uBlockOrigin/uBlock-issues/issues/2191

This is due to an erroneous space in the preparser

! #include fanboy_social_specific_uBO.txt should be !#include fanboy_social_specific_uBO.txt at line 12954 of fanboy-social.txt

Yuki2718 commented 4 weeks ago

What? !#include fanboy_social_specific_uBO.txt is at L1123 of fanboy_social_specific_hide.txt and `fanboy_social_specific_uBO.txt is correctly included in EasyList – Social Widgets.

Khrin commented 4 weeks ago

not reproducible

Squall-Leonhart commented 4 weeks ago

What? !#include fanboy_social_specific_uBO.txt is at L1123 of fanboy_social_specific_hide.txt and `fanboy_social_specific_uBO.txt is correctly included in EasyList – Social Widgets.

It is correct in this file, it is incorrect in fanboy-socials.txt because fop.py copies the line wrong into fanboy-socials.txt Nowhere did i mention EasyList-Socials. - Note saving the txt file when viewed from a browser is actually masking the issue somehow, but if you open the fanboy-socials.txt in an actions tar you will see the space in the preparser include.