search

easylist / easylist

EasyList filter subscription (EasyList, EasyPrivacy, EasyList Cookie, Fanboy's Social/Annoyances/Notifications Blocking List)
https://easylist.to
2.2k stars 711 forks source link

GameReactor.* - Blocked videos (EasyList) #3600

Closed THEtomaso closed 5 years ago

THEtomaso commented 5 years ago

Affected sites:

https://www.gamereactor.asia/
https://www.gamereactor.cn/
https://www.gamereactor.de/
https://www.gamereactor.dk/
https://www.gamereactor.es/
https://www.gamereactor.eu/
https://www.gamereactor.fi/
https://www.gamereactor.fr/
https://www.gamereactor.it/
https://www.gamereactor.nl/
https://www.gamereactor.no/
https://www.gamereactor.pl/
https://www.gamereactor.pt/
https://www.gamereactor.se/

Issue:

The rules to block pre-roll ads also prevents video playback.

Example:

https://www.gamereactor.eu/video/

Screenshot (Blocked video):

filterissue-gamereactor1

Problem filter:

Problem rules:

/delivery/fc.
/openx.$domain=~openx.tv
/www/delivery/*

Elaboration:

A new rule is needed, to bypass the ads and allow video playback.

Note (additional issue):

If you browse the sites, and open a few articles, a interstitial ad will appear. It would be nice if this could be bypassed too.

Screenshot (interstitial ad):

filterissue-gamereactor2

--

THEtomaso commented 5 years ago

@okiehsch: Something for uBO filters perhaps?

okiehsch commented 5 years ago

If I go to https://www.gamereactor.eu/video/ I get redirected to

https://www.gamereactor.eu/video/447173/Trials+of+Mana+Remake+Collection+of+Mana+Reveal+Trailer

and the video starts playing immediately.

THEtomaso commented 5 years ago

Must be some regional differences at work again then.

From my end, the EasyList rules breaks video playback for ALL of the GameReactor domains! However, if I disable the problematic rules, like this:

/delivery/fc.$badfilter
/openx.$domain=~openx.tv,badfilter
/www/delivery/*$badfilter

..then I get the following results:

https://www.gamereactor.asia/video/ = No ads
https://www.gamereactor.cn/video/   = No ads
https://www.gamereactor.de/video/   = No ads
https://www.gamereactor.dk/video/   = Ads
https://www.gamereactor.es/video/   = No ads
https://www.gamereactor.eu/video/   = Ads
https://www.gamereactor.fi/video/   = Ads
https://www.gamereactor.fr/video/   = No ads
https://www.gamereactor.it/video/   = No ads
https://www.gamereactor.nl/video/   = No ads
https://www.gamereactor.no/video/   = Ads
https://www.gamereactor.pl/video/   = No ads
https://www.gamereactor.pt/video/   = No ads
https://www.gamereactor.se/video/   = Ads

No matter which one of the domains above I visit, the videos are fetched from gamereactor.dk.

@DandelionSprout: Since we're connecting from the same region, would you mind taking a look at this issue?

PS: If you're using 'hpHosts' Ad and tracking servers' and/or 'Schacks Adblock Plus liste', you need to add this $badfilter rule too, when testing: ||openx.gamereactor.dk^$badfilter

DandelionSprout commented 5 years ago

As a resident of the Kingdom of Norway, I can confirm the breakage of https://www.gamereactor.no/grtv/447213/New+Super+Luckys+Tale+E3+Trailer/ and https://www.gamereactor.se/grtv/447213/New+Super+Luckys+Tale+E3+Trailer/. image

This appears to me to be due to a relatively clever choice by Gamereactor to not load the actual video before it has loaded the preroll ad, making this too difficult even for me to attempt to work around as I can't use my expertise in writing hiding rules for it.

Using the latter example page as my testing ground, so that I could piggyback onto Frellwit's Swedish Filters to see if he had written a fix for it (and if he had, to copy the entries into my list with only minor modifications), it appears that he hasn't. He's written entries to remove the ads during the 5sec waiting period (when using the $badfilter entries above), but not for unbreaking EasyList's openx breakage.

Making matters even more difficult for testing purposes, is that sometimes upon loading a video page they roll openx preroll ads, while other times (20~25% of the time) they seemingly don't and the video starts straight away. I have not been able to find a consistent pattern in either direction, despite 20min of trying to find one.

okiehsch commented 5 years ago

@DandelionSprout I tried 

https://www.gamereactor.no/video/447213/New+Super+Luckys+Tale+E3+Trailer/

with a non norwegian IP and your list enabled and the video is indeed permanently broken on my end using Chromium/Chrome. This is caused by ||gamereactor.*/lay/js/managebanners.js^$important,script in your list as far as I can see. That is the reason why I could not reproduce before, I did test without your list enabled.

Try adding ||gamereactor.*/lay/js/managebanners.js^$important,script,badfilter and go to https://www.gamereactor.no/video/447213/New+Super+Luckys+Tale+E3+Trailer if you still see a blank video try reloading one time. All videos should work after that, they do on my end.

DandelionSprout commented 5 years ago

I must indeed admit that my list's Gamereactor entries are pretty much copies of the ones that were in Frellwit's list ~18 months ago, and that they're far overdue for an update on my end, regardless of whether this issue report had been created or not.

THEtomaso commented 5 years ago

Try adding ||gamereactor.*/lay/js/managebanners.js^$important,script,badfilter

The correct entry would actually be this: ||gamereactor.*/lay/js/manageBanners.js^$script,important,badfilter ..but this doesn't matter at all, from my end. It's the EasyList rules (which I've pointed out before) that breaks the videos, not DandelionSprout's rule!

okiehsch commented 5 years ago

image

image

DandelionSprout commented 5 years ago

I've now commited a pretty large update of my list's Gamereactor entries, directly based on Frellwit's entries.

If the commit doesn't fix the problem, then it's probably on EasyList's end; since if the problem was in my list and the commit didn't fix it, it'd mean that Frellwit's list would've had the same problem all along for months when visiting gamereactor.se, which'd be unlikely.

okiehsch commented 5 years ago

The video https://www.gamereactor.se/grtv/447213/New+Super+Luckys+Tale+E3+Trailer is permanently broken if I enable the swedish regional list.

@DandelionSprout

  1. Go to https://www.gamereactor.no/video/447213/New+Super+Luckys+Tale+E3+Trailer
  2. Disable your regional list.
  3. Reload the page
  4. Click the video or reload the page one more time

Is the video still broken on your end?

I am not saying that the site did not change something or that the site was broken for months only because of your filters.

DandelionSprout commented 5 years ago

Upon testing your (okiehsch) scenario above, I am in fact able to confirm that you are in fact right, but with one important caveat.

On .no and .dk, reloading the page leads me to an interstition page that'd normally be used to display an ad. On .eu the interstition page is in fact skipped after a split-second, and I can't figure out which list/entry/extension that causes such a positive effect.

okiehsch commented 5 years ago

If I enable your list and leave ||gamereactor.*/lay/js/managebanners.js^$important,script untouched. A different fix working on my end is

gamereactor.*##+js(nano-setTimeout-booster.js)
@@||openx.gamereactor.dk/www/delivery/fc.php$xhr,domain=gamereactor.no
||media.gamereactor.dk/prerolls/*$media,redirect=noopmp4-1s,domain=gamereactor.no
lassekongo83 commented 5 years ago

redirect=noopmp3-0.1s can be used instead. Then there's no need for the booster.

Khrin commented 5 years ago

@THEtomaso : With a norwegian IP address and using Firefox and ABP or Ublock origin I don't have any video issues on gamereactor.no and all start regularly.

krystian3w commented 5 years ago

@lassekongo83 tested rewrite in ABP? Also support 0.1s mp3 file.

Specs: https://help.eyeo.com/en/adblockplus/how-to-write-filters#rewrite

lassekongo83 commented 5 years ago

That's something https://github.com/abp-filters/abp-filters-anti-cv can use. I only write filters for uBO.

krystian3w commented 5 years ago

rewrite I suppose still works from any subscribed list.

THEtomaso commented 5 years ago

With the latest filter updates, I get these results:

Chromium-ungoogled:

https://www.gamereactor.asia/video/ = Playback still broken!
https://www.gamereactor.cn/video/   = Playback still broken!
https://www.gamereactor.de/video/   = Playback still broken!
https://www.gamereactor.dk/video/   = "Spring over" activates by itself, and the videos play.
https://www.gamereactor.es/video/   = Playback still broken!
https://www.gamereactor.eu/video/   = Playback still broken!
https://www.gamereactor.fi/video/   = Playback still broken!
https://www.gamereactor.fr/video/   = Playback still broken!
https://www.gamereactor.it/video/   = Playback still broken!
https://www.gamereactor.nl/video/   = Playback still broken!
https://www.gamereactor.no/video/   = "Hopp over" activates by itself, and the videos play.
https://www.gamereactor.pl/video/   = Playback still broken!
https://www.gamereactor.pt/video/   = Playback still broken!
https://www.gamereactor.se/video/   = "Hoppa" activates by itself, and the videos play.
Pale Moon:

https://www.gamereactor.asia/video/ = Playback still broken!
https://www.gamereactor.cn/video/   = Playback still broken!
https://www.gamereactor.de/video/   = Playback still broken!
https://www.gamereactor.dk/video/   = Videos play, but only after cliking on "Spring over".
https://www.gamereactor.es/video/   = Playback still broken!
https://www.gamereactor.eu/video/   = Playback still broken!
https://www.gamereactor.fi/video/   = Playback still broken!
https://www.gamereactor.fr/video/   = Playback still broken!
https://www.gamereactor.it/video/   = Playback still broken!
https://www.gamereactor.nl/video/   = Playback still broken!
https://www.gamereactor.no/video/   = Videos play, but only after cliking on "Hopp over".
https://www.gamereactor.pl/video/   = Playback still broken!
https://www.gamereactor.pt/video/   = Playback still broken!
https://www.gamereactor.se/video/   = Videos play, but only after cliking on "Hoppa".

The problem rules are still the ad-blocking ones, found in EasyList, which I pointed out in the first post.

Screenshots:

filterissue-gamereactor3 filterissue-gamereactor4 filterissue-gamereactor5

ryanbr commented 5 years ago

Closing this, I don't see this being worked out.