Closed emiliou4756 closed 4 years ago
https://github.com/easylist/easylistgermany/commit/a37e16c6cffa2428bf1f8c271a167e30200ad1f8 https://github.com/easylist/easylist/commit/03042e6172fb5466aa4a537ac73eae84467f1f39 https://github.com/easylist/easylist/commit/e146cf33959684e6a8da2d51ce48aa313fafb35b https://github.com/easylist/easylist/commit/6999a4d995f6e5f788a24e6c10650f6ca5001761
Ads on godmode-trader.de seem to appear due to @@||godmode-trader.de^$ghide
in uBlock filters. This should either be removed if no longer needed or site-specific lement hiding filters should be added there.
These are generic enough to be added to EasyList.
thx.
more here:
https://www.ariva.de/dax-index/news or https://www.ariva.de/goldpreis-gold-kurs/chart?t=year&boerse_id=136 (footer---ad not always shown)
https://www.ariva.de/news/dramatische-oelpreis-auswirkungen-deshalb-muessen-infineon-8360384
https://www.finanznachrichten.de/nachrichten-aktien/wirecard-ag.htm
https://aktienkurs-orderbuch.finanznachrichten.de/wdi.htm
same url, now footer:
https://www.wallstreet-online.de
same url, footer:
https://www.wallstreet-online.de/indizes/dax/signale
https://www.wallstreet-online.de (mobile view - small window)
https://www.wallstreet-online.de - above footer
https://www.wallstreet-online.de/indizes/dax (mobile view - small window)
https://www.wallstreet-online.de/aktien/teamviewer-aktie
small view same url:
middle in the homepage:
https://www.boersennews.de/markt/aktien/detail/de0006231004/
-> also banner above footer
https://www.boersennews.de/markt/
https://www.boersennews.de/markt/indizes/detail/de0008469008/
https://www.boersennews.de/community/diskussion/wirecard/448/
@emiliou4756 thanks, I'll check this soonish.
@kulfoon I don't understand..how would I know that?
If I think a filter is good enough to be generic, I add it to EasyList as it could potentially block/hide something on another page. I doubt publicwww.com crawled every website in the world. So you just don't know if it will work on another site right now or even in the future. I don't understand how /adspace_finative-$domain=www.ariva.de
is "more logical and efficient" than /adspace_finative-
. Can you elaborate? The site-specific one will only work on www.ariva.de
. How is that more more logical and efficient if adding it without the $domain=
option could potentially block the same or a similar request on another page? I don't see any advantage in using the site-specific one instead.
But most of them, and definately all most important ones.
https://publicwww.com/: 536 229 312 web pages indexed
https://www.internetlivestats.com/total-number-of-websites/: 1 766 000 000+ Websites online right now
Nor you, also having just 1 affected website among 1 billion websites indexed by publicwww it's unlikely to find another one, as it shows obvious thing that such a single website with a unique dom/network request's name is just a single alone random case in the ocean.
If there is a likelihood, it will usually end up in EasyList as a generic filter.
As seen, it's all about efficiency/performance/resources saving
In https://github.com/easylist/easylistgermany/issues/70#issuecomment-617803752 you mention generic blocking rules while in uBO there is a warning for generic element hiding rules. Currently there are 8900 lines in easylist_general_block.txt and easylist_general_block_dimensions.txt. That's without generic adserver (16188+1080) and third-party (1854+454) filters (lines =| filters as there are also some comments). I'm not aware of any perfomance issues with such filters. I know that processing and applying filters in general has been improved considerably in the last years in mayor adblock extesion and products such as Cliqz, Adblock Plus, AdBlock and I think Brave too.
@emiliou4756
https://www.ariva.de/news/dramatische-oelpreis-auswirkungen-deshalb-muessen-infineon-8360384
Showing due to @@||ariva.de^$ghide
in uBlock filters. It should be removed or add ariva.de##.werb_textlink
to uBlock filters.
regarding godmode an ariva: who maintains ublock filters?
here some others: https://www.zeit.de/zustimmung?url=https%3A%2F%2Fwww.zeit.de%2Findex https://www.spiegel.de/consent-a-?targetUrl=https%3A%2F%2Fwww.spiegel.de%2F https://www.mobiflip.de/shortnews/volkswagen-id3-ionity-preise-kosten-marketing/
@emiliou4756 ping @mapx-
Where do you see ads on the other sites?
https://github.com/uBlockOrigin/uBlock-issues/issues/738#issuecomment-619450820
Great, if it just was written in the tooltip I mentioned, that would be good, but it seems you are not of those who claim that their description may have been confusing/misleading and making you looking like denying your own tooltip, and making the one who was confused looking foolish, and locking a thread makes the one looking yet more foolish because he is unable to reply/defend. I didn't dig so deep into uBO, as I just sticked to what was suggested in the uBO's tooltip, thus I thought every added generic filter eats some cycles. But as seen, since now I won't trust at 100% to any tooltip anymore in any program. See: another similiar case
And locking threads and forcing people to answer elsewhere sucks, you did it not the first time, no further comment on such admins.
@emiliou4756 fixed anti adb warning for uBO (just enable uBO annoyances list) https://github.com/uBlockOrigin/uAssets/commit/0510542c588542bcb37e0551dba6d051f415b0d4
@monzta
on spiegel.de
(home page for example) , even disabling ghide
filter there are some blank placeholders
@monzta for the big placeholder see if helps:
spiegel.de##[data-component="HTMLEmbed"]
@mapx- always in private surfmode - sometimes in normal mode...
Spiegel:
Zeit:
@emiliou4756 It's not about ads or anti adblocking.
I tried for example spiegel.de##+js(aopr, document.cookie)
but it seems is breaking the comments and possibly other stuff.
Hello, all details (screenshots with marked ads) here:
https://github.com/uBlockOrigin/uAssets/issues/7270