search

easymodo / qimgv

Image viewer. Fast, easy to use. Optional video support.
GNU General Public License v3.0
2.46k stars 170 forks source link

register as windows default Photo viewer #318

Open Mr-Second opened 3 years ago

easymodo commented 3 years ago

installer asks you to set defaults, did it not work for you?

Mr-Second commented 3 years ago

😂sorry, I install the qimgv using Scoop, and there is no option of qimgv in windows default photo view

bradenhilton commented 3 years ago

I can confirm that I also have this issue when installing through Scoop. I recognise that this technically makes it a Scoop issue and not a qimgv issue, nonetheless if you could accommodate this, I for one would greatly appreciate it.

I will attempt to explain how the Scoop install process works in case you are not aware:

The Scoop install (non-video/video) doesn't run the installer, instead it simply downloads the zip and extracts it. I think this is because there is a heavy preference towards portable installs with Scoop (non-portable installers are typically avoided unless necessary).

A quick workaround could be to bundle the install script in https://github.com/easymodo/qimgv/issues/258#issuecomment-686728937 in an install(er)/windows (or similar) directory. It would probably be better to also provide an uninstall script to remove the file associations (and would likely be necessary for this method to be used in the Scoop install).

I unpacked the installer a while ago to see how Inno Setup sets file associations in an attempt to recreate the behaviour, but I got distracted by other things.

The mpv-git install for Scoop behaves in a similar way, by downloading a custom build of mpv which is bundled with the mpv-install script and simply extracting it, then suggesting that the user run the install script to set file associations. This way the install remains portable, and the user can decide if they want to further integrate it into their system.

Adding a section to the settings menu to set file associations etc. would perhaps be a better solution but is obviously more work, I'm also not sure how this would work on software that is cross-platform.

Failing all that, I suppose a non-portable Scoop install could be created. Does the installer automatically set file associations when installed through the command line in quiet/unattended mode? If not, is there a specific flag that enables this?