easymodo / qimgv

Image viewer. Fast, easy to use. Optional video support.
GNU General Public License v3.0
2.3k stars 160 forks source link

Some keystroke detection is broken [Qt 6.7.0] #539

Closed eddiezato closed 3 months ago

eddiezato commented 3 months ago

Specifically these keys are not detected by qimgv:

Win 11, latest qimgv-master, Qt 6.7.0, msys2/ucrt64

eddiezato commented 3 months ago

Had to change the keycodes for the problem buttons here: https://github.com/easymodo/qimgv/blob/52f482b6451d24b4b7f4fe2ca763b0be9d24c4c1/qimgv/utils/inputmap.cpp#L28

keyMap.insert( 57426 , "Ins" );
keyMap.insert( 57415 , "Home" );
keyMap.insert( 57417 , "PgUp" );
keyMap.insert( 57427 , "Del" );
keyMap.insert( 57423 , "End" );
keyMap.insert( 57425 , "PgDown" );
keyMap.insert( 57416 , "Up" );
keyMap.insert( 57437 , "Menu" );
keyMap.insert( 57419 , "Left" );
keyMap.insert( 57424 , "Down" );
keyMap.insert( 57421 , "Right" );
// numpad
keyMap.insert( 57413 , "NumLock" );
keyMap.insert( 57397 , "/" );
keyMap.insert( 57372 , "Enter" );

Dunno why they suddenly stopped working.

easymodo commented 3 months ago

that's weird, idk why they had to change the codes

qt 6.7 on linux does not have this issue

eddiezato commented 3 months ago

What bothers me is, did they really change these codes for win? Or is it just some local issue on my system?

easymodo commented 3 months ago

Okay there is indeed an issue ( mingw64/mingw-w64-x86_64-qt6-base 6.7.0-1 )

No idea why they had to change them. Maybe some bug