easymodo
commented
1 month ago the more I look at this script the more Windows-specific I see it is
Yeah it's strictly for windows / msys2, just a convenience thing. So I guess there's no point changing the flag
A bit of a nitpick, but I noticed that this file wasn't executable, despite having a shebang. This PR changes the file mode to be executable. For now it doesn't matter for the workflow since that's running on Windows (and all files are executable on Windows AFAIK), but can help users who decide to run this script (for whatever reason) on a Unix-like system.
Edit: the more I look at this script the more Windows-specific I see it is (I'm not sure about its behavior in WSL), so perhaps it shouldn't be executable to discourage running this script locally on a Unix-like system. Or a quick check can be placed at the top to exit early if the OS is not Windows, and tell the user to actually read the compilation instructions :laughing: