easymotion / vim-easymotion

Vim motions on speed!
http://www.vim.org/scripts/script.php?script_id=3526
7.44k stars 357 forks source link

Fail of overwin-* Commands in Vim8 :terminal -- E605 Cannot make a terminal with running job modifiable #368

Open cesheridan opened 6 years ago

cesheridan commented 6 years ago

An outstanding plugin !

The issue is not a problem w/ the plugin's internals, rather it's in an interaction with the new Vim8 terminal, and not surprising given the nature of terminals.

Charles

overwin-line and -f and likely all overwin-* commands fail when the active tab has a Vim8 :terminal:

Error detected while processing function EasyMotion#overwin#line[1]..EasyMotion#overwin#move[1]..<SNR>155_move[2]..192[1]..193[7]..196[20]..200[2]..206[26]..<SNR>155_throw:
line    1:
E605: Exception not caught: vital: HitAHint.Motion: function EasyMotion#overwin#line[1]..EasyMotion#overwin#move[1]..<SNR>155_move[2]..192[1]..193[7]..196[20]..200[2]..206, line 15 Vim(for):E716: Key not present in Dictionary: 1  
GCorbel commented 6 years ago

I have the same issue. Any updates?

simlei commented 6 years ago

But it is really a problem with the plug-in internals as it imposes restrictions on the buffers that are open in the tab to be usable. There is a middle ground where it would become a state of peaceful coexistence, achieved by simply ignoring unmodifiable buffers. I think everyone using the terminal would welcome a full-functioning impl., but I think that may be just out of scope as the internals are implemented today.

That aside, the OP is correct. Really an outstanding plug-in! But please let me use terminals in the same tab where I would use Overwin :) So sorry I am just a VIM beginner and don't know enough about vim scripting and internals :/

justinmk commented 6 years ago

see https://github.com/easymotion/vim-easymotion/issues/246